Sharethrough Bid Adapter : Support for dsa transparency #11191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from prebid:master
patmmccann
reviewed
Mar 12, 2024
patmmccann
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Extensive object validation doesn't belong in bid adapters, please move to a library to avoid code duplication.
It also seems really expensive to validate something set once in publisher config billions of times, we have an object validation module for this purpose
patmmccann
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Build support for DSA Transparency in Prebid to satisfy a market regulation in the EU.